-
-
Notifications
You must be signed in to change notification settings - Fork 23.6k
[4.3] Add CLIP_SPACE_FAR built-in to spatial shader
#108360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.3
Are you sure you want to change the base?
Conversation
bcf8ec1 to
002de25
Compare
|
Is there a specific reason why this particular feature should be backported to 4.3? |
|
I think backporting this could make sense. Shaders that write to That said, as we keep moving forward, and Godot 4.3 gets older and older, I think this makes less sense. |
|
@paddy-exe I have a project which tries to target multiple Godot versions and renderers, and makes use of this constant. The lack of this feature is the biggest problem inhibiting 4.3 support. I would greatly appreciate having this backported. In my case it's an engine module, so just having this in the 4.3 branch is sufficient, even if it's not in a patch release yet. |
|
@dsnopek @aaronfranke Be that as it may, I believe this backport would set a bad precedent for backporting features to a previous release branch. The same logic could probably be used by several other plugin/extension developers and their cases (both for past and future versions). I will put this up for discussion at the next rendering meeting. |
|
After discussing this in the rendering meeting, the team has concluded that the decision if this should be merged belongs more to the release management team. Moreover, it declared the PR helpful for shader authors and a very safe change. |
002de25 to
971f0e8
Compare
Manual backport of PR #95057 to the Godot 4.3 branch because there were conflicts. I tested that this works.
I resolved conflicts, but otherwise the code is entirely from @Chaosus's original PR.